Skip to content

Conversation

whoAbhishekSah
Copy link
Member

Migrate Admin Prospect RPCs to ConnectRPC server

The following RPCs are migrated.

  • CreateProspectPublic
  • CreateProspect
  • ListProspects
  • GetProspect
  • UpdateProspect
  • DeleteProspect

The implementation of the handlers is similar to that of the gRPC handlers.
I have just made it compatible with the ConnectRPC signature.
We have used connect errors instead of gRPC errors.

Copy link

vercel bot commented Sep 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
frontier Ready Ready Preview Comment Sep 15, 2025 7:02am

@coveralls
Copy link

coveralls commented Sep 15, 2025

Pull Request Test Coverage Report for Build 17724770315

Details

  • 174 of 224 (77.68%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 32.112%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/v1beta1connect/prospect.go 174 224 77.68%
Totals Coverage Status
Change from base Build 17724740792: 0.3%
Covered Lines: 10999
Relevant Lines: 34252

💛 - Coveralls

@whoAbhishekSah whoAbhishekSah merged commit 786485e into main Sep 15, 2025
7 checks passed
@whoAbhishekSah whoAbhishekSah deleted the connectrpc_admin_prospect_rpc branch September 15, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants