Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: setup cache for installing dependencies #1297

Merged
merged 3 commits into from
Jun 14, 2023
Merged

ci: setup cache for installing dependencies #1297

merged 3 commits into from
Jun 14, 2023

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Jun 14, 2023 •
edited
Loading

Fixes #1221

Install time reduced from 5mins to 25s 🔥

Before

Screenshot 2023-06-14 at 7 20 38 AM

After

Example run.

Screenshot 2023-06-14 at 7 19 05 AM Screenshot 2023-06-14 at 7 21 16 AM

@changeset-bot
Copy link

changeset-bot bot commented Jun 14, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: e2bbaf1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 14, 2023 •
edited
Loading

✅ PR title follows Conventional Commits specification.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 14, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e2bbaf1:

Sandbox Source
razorpay/blade: basic Configuration

@bundlemon
Copy link

bundlemon bot commented Jun 14, 2023 •
edited
Loading

BundleMon

Unchanged files (14)
Status Path Size Limits
✅ Web Components
build/components/index.web.js
 250.81KB -
✅ React Native Components
build/components/index.native.js
 164.72KB -
✅ Web Tokens
build/tokens/index.web.js
 33.64KB -
✅ React Native Tokens
build/tokens/index.native.js
 30.09KB -
✅ Web Utils
build/utils/index.web.js
 29.63KB -
✅ React Native Utils
build/utils/index.native.js
 27.63KB -
✅ CSS Theme Tokens
build/css/bankingThemeLightDesktop.css
 3.69KB -
✅ CSS Theme Tokens
build/css/paymentThemeDarkDesktop.css
 3.69KB -
✅ CSS Theme Tokens
build/css/bankingThemeLightMobile.css
 3.68KB -
✅ CSS Theme Tokens
build/css/paymentThemeLightDesktop.css
 3.68KB -
✅ CSS Theme Tokens
build/css/paymentThemeDarkMobile.css
 3.68KB -
✅ CSS Theme Tokens
build/css/paymentThemeLightMobile.css
 3.67KB -
✅ CSS Theme Tokens
build/css/bankingThemeDarkDesktop.css
 3.66KB -
✅ CSS Theme Tokens
build/css/bankingThemeDarkMobile.css
 3.65KB -

Total files change +8B 0%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@snitin315 snitin315 marked this pull request as ready for review June 14, 2023 01:51
saurabhdaware
saurabhdaware previously approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@saurabhdaware saurabhdaware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🔥

divyanshu013
divyanshu013 previously approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@divyanshu013 divyanshu013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@saurabhdaware saurabhdaware merged commit d2dee56 into master Jun 14, 2023
@saurabhdaware saurabhdaware deleted the ci/cache-deps branch June 14, 2023 05:15
anuraghazra pushed a commit that referenced this pull request Apr 9, 2024
@snitin315
ci: setup cache for installing dependencies (#1297)
ef5c196 
* ci: setup cache for installing dependencies

* ci: update action

* chore: update comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saurabhdaware saurabhdaware saurabhdaware approved these changes

@divyanshu013 divyanshu013 divyanshu013 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workflow: blade-validate workflow's Install dependency step is failing to hit cache
3 participants
@snitin315 @divyanshu013 @saurabhdaware