Skip to content

Conversation

Marvin182
Copy link
Contributor

Horwards date library has grown to a few headers and I think it is cleaner to have them in a subfolder of the standard include path.
This is in line with my homebrew formula for date/sqlpp11: https://github.com/Marvin182/homebrew-zapfhahn/tree/master/Formula

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.913% when pulling 1c848ea on Marvin182:master into 81ca67c on rbock:master.

@rbock rbock merged commit 651e4ed into rbock:master Oct 21, 2016
@rbock
Copy link
Owner

rbock commented Oct 21, 2016

Marvin,

Thanks! I like the name "homebrew-zapfhahn" :-)

I understand from your README that your formulas are not well enough tested to be integrated into main tap. Would you say it makes sense to point others to them, though? If so, please create another pull request for the README to add a link. I'd say next to the Linux install text.

@Marvin182
Copy link
Contributor Author

Hi :)

Thoughts on that:

  1. I created a pull requests with an install section, describing both install in general and with homebrew.

  2. My formula only contains options for the sqlite3 and mysql connector. Authors of other connectors are welcome to add install instructions and dependencies for their connectors.

  3. The formula has an --HEAD option to use the latest version of the master branch, but for the stable version we have to update the formula after each release. I might be the wrong person to keep track of that, but you can create pull requests on to homebrew-zapfhahn for it.

  4. I once wanted to push a formula to one of the official taps and it was a little disasters as they kept coming back with comments about little style changes I should do. Those style requirements weren't documented. When send be back and forth between two taps I decided to make my own tap. Everybody can use them, they are just harder to find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants