-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataFactory methods to create from existing term and quad | closes #137 #158
Conversation
👋 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great to support plain objects as well and make these methods more robust, e.g., not requiring original
to have a .equals
method.
I'm pretty sure that with #142 we could simply say, such that |
Can we do it the other way and require that newly created instance will have |
@elf-pavlik I think that is exactly what I am proposing... do we have a misunderstanding? |
Thanks for commit @blake-regalia 👍 |
fixed markup
@dmitrizagidulin I noticed you had some suggestions in #81 (comment) would you like to review this PR? |
As discussed in #137