Allow the polyfill to kick in with PHPUnit 8.x #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHPUnit 8.x deprecated the `assertArraySubset()` functionality, PHPUnit 9.x removed it.
Up to now, this package would only "kick in" in combination with PHPUnit 9.x to polyfill the functionality.
The combined changes in this commit will allow for this package to also "kick in" in combination with PHPUnit 8.x, preventing the PHPUnit native deprecation for using `assertArraySubset()` from being thrown.
This commit also includes CI changes to safeguard the correct functioning of the code when used with PHPUnit 8.x.
Notes:
* The main change is in the autoloader, most other files only contain changed annotations.
* The only functional change needed was a work-around for the PHPUnit `InvalidArgumentException`, which was only introduced in PHPUnit 8.4.0.
* This commit does change the minimum PHP version code within the actual polyfill has to be compatible with.
Previously, the code has to be compatible with PHP 7.3 and higher (minimum supported PHP version for PHPUnit 9.x).
Now, the code has to be compatible with PHP **7.2** and higher (minimum supported PHP version for PHPUnit 8.x).
Fixes 50
joshua-bn
reviewed
Dec 27, 2021
joshua-bn
approved these changes
Dec 27, 2021
rdohms
approved these changes
Feb 13, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPUnit 8.x deprecated the
assertArraySubset()functionality, PHPUnit 9.x removed it.Up to now, this package would only "kick in" in combination with PHPUnit 9.x to polyfill the functionality.
The combined changes in this commit will allow for this package to also "kick in" in combination with PHPUnit 8.x, preventing the PHPUnit native deprecation for using
assertArraySubset()from being thrown.This commit also includes CI changes to safeguard the correct functioning of the code when used with PHPUnit 8.x.
Notes:
InvalidArgumentException, which was only introduced in PHPUnit 8.4.0.Previously, the code has to be compatible with PHP 7.3 and higher (minimum supported PHP version for PHPUnit 9.x).
Now, the code has to be compatible with PHP 7.2 and higher (minimum supported PHP version for PHPUnit 8.x).
Fixes #50