Skip to content

🐛 [Commands] Fix bug commands creating config file anyways #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2024
Merged

🐛 [Commands] Fix bug commands creating config file anyways #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Command/DeployCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,15 @@ protected function initialize(InputInterface $input, OutputInterface $output): v

if (null !== $customConfigPath && is_readable($customConfigPath)) {
$this->configFilePath = $customConfigPath;

return;
}

$defaultConfigPath = SymfonyConfigPathGuesser::guess($this->projectDir, $input->getArgument('stage'));
if (is_readable($defaultConfigPath)) {
$this->configFilePath = $defaultConfigPath;

return;
}

$this->createDefaultConfigFile($input, $output, $defaultConfigPath, $input->getArgument('stage'));
Expand Down
4 changes: 4 additions & 0 deletions src/Command/RollbackCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,15 @@ protected function initialize(InputInterface $input, OutputInterface $output): v

if (null !== $customConfigPath && is_readable($customConfigPath)) {
$this->configFilePath = $customConfigPath;

return;
}

$defaultConfigPath = SymfonyConfigPathGuesser::guess($this->projectDir, $input->getArgument('stage'));
if (is_readable($defaultConfigPath)) {
$this->configFilePath = $defaultConfigPath;

return;
}

throw new \RuntimeException(sprintf("The default configuration file does not exist or it's not readable, and no custom configuration file was given either. Create the '%s' configuration file and run this command again.", $defaultConfigPath));
Expand Down