Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make target work like container #102

Merged
merged 1 commit into from Jul 13, 2016
Merged

Make target work like container #102

merged 1 commit into from Jul 13, 2016

Conversation

taion
Copy link
Member

@taion taion commented Jul 12, 2016

No description provided.

@taion
Copy link
Member Author

taion commented Jul 12, 2016

Arguably this is breaking but anybody actually reading the props in the arguments to the target function is doing something utterly bizarre.

@taion taion mentioned this pull request Jul 12, 2016
Merged
@jquense
Copy link
Member

jquense commented Jul 12, 2016

i might the one person doing something bizarre, let me confirm there isn't a reasonable use case...

@taion
Copy link
Member Author

taion commented Jul 12, 2016

It seems really weird for a callback to be able to read the props of a different component.

@jquense
Copy link
Member

jquense commented Jul 13, 2016

LGTM

@jquense jquense merged commit e32f1c5 into master Jul 13, 2016
@jquense jquense deleted the target branch July 13, 2016 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@taion @jquense