Skip to content

[added] disabled prop to rootClose #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2016
Merged

[added] disabled prop to rootClose #93

merged 1 commit into from
Jun 7, 2016

Conversation

jquense
Copy link
Member

@jquense jquense commented Jun 6, 2016

Allow the child to remain mounted while conditionally disabling the behavior

@taion
Copy link
Member

taion commented Jun 6, 2016

I meant to ask – do you remember why we (I) did this instead of checking something like domHelpers.contains(ReactDOM.findDOMNode(this), event.target) or something?

@jquense
Copy link
Member Author

jquense commented Jun 7, 2016

I don't remember hmm...this approach should be more performant, since its not doing a contains, tho contains is super fast actually. I don't know :P

@taion
Copy link
Member

taion commented Jun 7, 2016

It'd also skip the bizarre wrapper.

@jquense
Copy link
Member Author

jquense commented Jun 7, 2016

probably worth revisiting

@jquense jquense merged commit ac2784a into master Jun 7, 2016
@jquense jquense deleted the root-close branch June 7, 2016 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants