Skip to content

[added] PageItem links support #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2015
Merged

Conversation

mdziekon
Copy link
Contributor

@mdziekon mdziekon commented Aug 8, 2015

This PR implements links support for <PageItem> component as <PageItemLink>.

This is how visual test looks like:
react-router-bootstrap-page-item-link

@AlexKVal
Copy link
Member

AlexKVal commented Aug 9, 2015

LGTM

Need one more sign from @react-bootstrap/collaborators

@mtscout6
Copy link
Member

LGTM, but it looks like it won't auto merge. Can you rebase these changes on the latest master branch?

@mdziekon
Copy link
Contributor Author

Sure, rebase done

jquense added a commit that referenced this pull request Aug 10, 2015
[added] PageItem links support
@jquense jquense merged commit 1b67b1a into react-bootstrap:master Aug 10, 2015
@AlexKVal
Copy link
Member

@react-bootstrap/owners should we roll the next patch version with all these new components merged ? 😄

@taion
Copy link
Member

taion commented Aug 10, 2015

Done.

@AlexKVal
Copy link
Member

@mdziekon Thank you for all your contributions 🍒
Next version 4e11d3d with them is in the wild already 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants