Skip to content

Update for React Router v2 #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 31, 2015
Merged

Update for React Router v2 #145

merged 1 commit into from
Dec 31, 2015

Conversation

taion
Copy link
Member

@taion taion commented Dec 30, 2015

No description provided.

@AlexKVal
Copy link
Member

Shouldn't the commit header start with [changed]... for these changes being reflected in the CHANGELOG.md ? 😉
And probably it should be somewhere (Readme?) pointed out that from the next release it is only compatible with RR@2+.
Otherwise everything seems OK.

@taion
Copy link
Member Author

taion commented Dec 31, 2015

Will do.

@taion
Copy link
Member Author

taion commented Dec 31, 2015

Updated. Will merge when build goes green (unless someone beats me to it).

jquense added a commit that referenced this pull request Dec 31, 2015
@jquense
Merge pull request #145 from taion/router-2
6274e55 
Update for React Router v2
@jquense jquense merged commit 6274e55 into react-bootstrap:master Dec 31, 2015
@taion taion deleted the router-2 branch December 31, 2015 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taion @AlexKVal @jquense