Skip to content

Conversation

DylanVann
Copy link

rc-util has a peerDependency:

  "peerDependencies": {
    "react": "^15.0.0 || ^16.0.0",
    "react-dom": "^15.0.0 || ^16.0.0"
  },

This package depends on rc-util so it must either have react and react-dom in dependencies or in peerDependencies.

Currently this prevents using Ant Design with Yarn Berry.

image

If this is accepted I will make this change to other rc-* repos.

image

@vercel
Copy link

vercel bot commented Dec 9, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/react-component/rc-animate/6hjlqal0w
🌍 Preview: https://rc-animate-git-fork-dylanvann-add-peer.react-component.now.sh

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.78% when pulling e3a0d41 on DylanVann:add-peer into a1385aa on react-component:master.

@yoyo837
Copy link
Member

yoyo837 commented Nov 18, 2020

Close by #116

@yoyo837 yoyo837 closed this Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants