Skip to content

Conversation

Wxh16144
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Jan 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
collapse ✅ Ready (Inspect) Visit Preview Jan 13, 2023 at 6:28AM (UTC)

@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Merging #299 (70e39a0) into master (da97f2d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #299   +/-   ##
=======================================
  Coverage   98.85%   98.85%           
=======================================
  Files           4        4           
  Lines          87       87           
  Branches       33       33           
=======================================
  Hits           86       86           
  Misses          1        1           
Impacted Files Coverage Δ
src/index.tsx 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

src/index.tsx Outdated
Comment on lines 3 to 7
export type {
CollapsePanelProps,
CollapseProps,
CollapsibleType,
} from './interface';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可不可以用 CollapseProps['xxx'] 代替?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

原来没暴露出去的,那我调整一下 TS 类型推导

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我看了一下 antd 也没用到这个类型推导。是否要 export 出去呢

export type { 
  CollapseProps,
  CollapsePanelProps
} from './interface';

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这两个感觉可以的

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants