Skip to content

Portal wrapper #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 11, 2019
Merged

Portal wrapper #124

merged 6 commits into from
Jul 11, 2019

Conversation

jljsj33
Copy link
Member

@jljsj33 jljsj33 commented Jul 10, 2019 •
edited
Loading

与 drawer 同用一个 portal。。

#123 在这里没问题。。那个关了吧。。

ant-design/ant-design#17323

@jljsj33 jljsj33 requested a review from afc163 July 10, 2019 13:47
@coveralls
Copy link

coveralls commented Jul 10, 2019 •
edited
Loading

Coverage Status

Coverage increased (+5.8%) to 90.11% when pulling 239cb07 on portal-wrapper into 281ee35 on master.

@jljsj33 jljsj33 mentioned this pull request Jul 10, 2019
Closed
@jljsj33 jljsj33 changed the title Portal wrapper [WIP] Portal wrapper Jul 10, 2019
@jljsj33 jljsj33 mentioned this pull request Jul 11, 2019
Closed
@jljsj33 jljsj33 changed the title [WIP] Portal wrapper Portal wrapper Jul 11, 2019
@jljsj33
Copy link
Member Author

jljsj33 commented Jul 11, 2019

@afc163 @zombieJ review 下。。

@jljsj33 jljsj33 requested a review from zombieJ July 11, 2019 04:09
@zombieJ
Copy link
Member

zombieJ commented Jul 11, 2019

是不是这个就不需要了？ #125
@jljsj33 @ztplz

@jljsj33 jljsj33 merged commit a2ce9be into master Jul 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the portal-wrapper branch July 11, 2019 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 Awaiting requested review from afc163

@zombieJ zombieJ Awaiting requested review from zombieJ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jljsj33 @coveralls @zombieJ