Skip to content

chore: move warning delay #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2020
Merged

chore: move warning delay #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/useForm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,11 +135,15 @@ export class FormStore {
};

private warningUnhooked = () => {
if (process.env.NODE_ENV !== 'production' && !this.formHooked) {
warning(
false,
'Instance created by `useForm` is not connected to any Form element. Forget to pass `form` prop?',
);
if (process.env.NODE_ENV !== 'production') {
setTimeout(() => {
if (!this.formHooked) {
warning(
false,
'Instance created by `useForm` is not connected to any Form element. Forget to pass `form` prop?',
);
}
});
}
};

Expand Down
3 changes: 3 additions & 0 deletions tests/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,6 +517,7 @@ describe('Form.Basic', () => {
});

it('warning if call function before set prop', () => {
jest.useFakeTimers();
resetWarned();
const errorSpy = jest.spyOn(console, 'error').mockImplementation(() => {});

Expand All @@ -529,10 +530,12 @@ describe('Form.Basic', () => {

mount(<Test />);

jest.runAllTimers();
expect(errorSpy).toHaveBeenCalledWith(
'Warning: Instance created by `useForm` is not connected to any Form element. Forget to pass `form` prop?',
);
errorSpy.mockRestore();
jest.useRealTimers();
});

it('filtering fields by meta', async () => {
Expand Down