feat: add() support index param #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
等下补个测试～ |
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
=======================================
Coverage 99.88% 99.88%
=======================================
Files 13 13
Lines 902 909 +7
Branches 199 194 -5
=======================================
+ Hits 901 908 +7
Misses 1 1
Continue to review full report at Codecov.
|
zombieJ
reviewed
Aug 5, 2020
src/List.tsx
Outdated
| */ | ||
| const operations: ListOperations = { | ||
| add: defaultValue => { | ||
| add: (defaultValue, index: number) => { |
| expect(getList().find(Field).length).toEqual(5); | ||
| expect(form.getFieldsValue()).toEqual({ | ||
| list: ['0', undefined, '1', '4', '2'], | ||
| }); |
There was a problem hiding this comment.
ok,这个在 validate 那组测试里面单独加了～
fireairforce
force-pushed
the
formList-add
branch
from
fef3bfa to
7d89f90
Compare
zombieJ
reviewed
Aug 7, 2020
| operation.add('1', 2); | ||
| }); | ||
| act(() => { | ||
| operation.add('2', -1); |
There was a problem hiding this comment.
这里容易让人误解，感觉需要加一个 warning，它只允许有效的正数。
zombieJ
reviewed
Aug 7, 2020
src/List.tsx
Outdated
| ) { | ||
| warning( | ||
| false, | ||
| 'The second parameter of the add function should be a valid positive number', |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref issue：ant-design/ant-design#26012