Skip to content

Conversation

jaworek
Copy link
Contributor

@jaworek jaworek commented Nov 9, 2020

NPM 7 automatically installs peer dependencies. Trying to update to React 17 causes error when installing @ant-design/icons
More info here: https://github.blog/2020-10-13-presenting-v7-0-0-of-the-npm-cli/

Based on the advice from Kent C. Dodds and Cory House, I updated peer dependency of React to be ">= 16.9.0"
Tweets: https://mobile.twitter.com/kentcdodds/status/1325565636303482880

NPM 7 automatically installs peer dependencies. Trying to update to React 17 causes error when installing @ant-design/icons
More info here: https://github.blog/2020-10-13-presenting-v7-0-0-of-the-npm-cli/

Based on the advice from Kent C. Dodds and Cory House, I updated peer dependency of React to be ">= 16.9.0"
Tweets: https://mobile.twitter.com/kentcdodds/status/1325565636303482880
@vercel
Copy link

vercel bot commented Nov 9, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/field-form/pr8pwtggs
✅ Preview: https://field-form-git-patch-1.react-component.vercel.app

@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #216 (3e99854) into master (fc01ed2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #216   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files          13       13           
  Lines         921      921           
  Branches      199      199           
=======================================
  Hits          920      920           
  Misses          1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc01ed2...3e99854. Read the comment docs.

@yoyo837 yoyo837 merged commit 2dab0b7 into react-component:master Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants