Skip to content

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Nov 12, 2020

dependencies 的字段在 renderProps 的 Field 下延迟一个 Promise 以确保 rules 保持同步更新。

@vercel
Copy link

vercel bot commented Nov 12, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/field-form/ju0vvzkyp
✅ Preview: https://field-form-git-fix-render-props-validate.react-component.vercel.app

@zombieJ
Copy link
Member Author

zombieJ commented Nov 12, 2020

@crazyair 来确认一下

Copy link
Contributor

@crazyair crazyair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #218 (946ce44) into master (12e8f5b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #218   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files          13       13           
  Lines         931      937    +6     
  Branches      201      203    +2     
=======================================
+ Hits          930      936    +6     
  Misses          1        1           
Impacted Files Coverage Δ
src/Field.tsx 100.00% <100.00%> (ø)
src/useForm.ts 99.71% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12e8f5b...946ce44. Read the comment docs.

@zombieJ
Copy link
Member Author

zombieJ commented Nov 13, 2020

测试挂的还是不少,发个 minor 以防万一

@zombieJ zombieJ requested a review from afc163 November 13, 2020 03:44
@zombieJ zombieJ merged commit 55de0f3 into master Nov 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-render-props-validate branch November 13, 2020 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants