Skip to content

Conversation

jueinin
Copy link
Contributor

@jueinin jueinin commented Mar 2, 2021

fix #ant-design/ant-design#29439

Besides, put the ...restProps behind, so that user can cover it

@vercel
Copy link

vercel bot commented Mar 2, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/field-form/ABwiVAa2HKMeUJ4QgmdXjqioyRjF
✅ Preview: https://field-form-git-fork-jueinin-master-react-component.vercel.app

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #278 (b985be7) into master (dda8717) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #278   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files          13       13           
  Lines         969      973    +4     
  Branches      229      230    +1     
=======================================
+ Hits          968      972    +4     
  Misses          1        1           
Impacted Files Coverage Δ
src/Form.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dda8717...5b22474. Read the comment docs.

@jueinin
Copy link
Contributor Author

jueinin commented Mar 6, 2021

Are there any other problems? could you merge this PR? Thanks!

@zombieJ
Copy link
Member

zombieJ commented Mar 11, 2021

feature branch please

@jueinin
Copy link
Contributor Author

jueinin commented Mar 12, 2021

@zombieJ this repo do not have a branch named feature. awkward...

@zombieJ
Copy link
Member

zombieJ commented Mar 12, 2021

My bad. That's OK.

@zombieJ zombieJ merged commit 74a22db into react-component:master Mar 12, 2021
@zombieJ
Copy link
Member

zombieJ commented Mar 12, 2021

+ rc-field-form@1.20.0

@zombieJ
Copy link
Member

zombieJ commented Mar 12, 2021

@jueinin , pls create PR to antd feature branch also. Thx~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants