Skip to content

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jun 1, 2021

本来以为要改 async-validator,好像勾一下也行了?

顺道做了一下:ant-design/ant-design#30016

@vercel
Copy link

vercel bot commented Jun 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/field-form/7Gvaa2a5PAYFhENJF4XUppmPWZzE
✅ Preview: https://field-form-git-warning-react-component.vercel.app

@zombieJ zombieJ changed the title feat: rules support warningOnly [WIP] feat: rules support warningOnly Jun 1, 2021
@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #304 (2f75e5d) into master (e118381) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #304   +/-   ##
=======================================
  Coverage   99.89%   99.90%           
=======================================
  Files          13       13           
  Lines         973     1005   +32     
  Branches      230      230           
=======================================
+ Hits          972     1004   +32     
  Misses          1        1           
Impacted Files Coverage Δ
src/FieldContext.ts 100.00% <ø> (ø)
src/utils/asyncUtil.ts 100.00% <ø> (ø)
src/Field.tsx 100.00% <100.00%> (ø)
src/useForm.ts 99.74% <100.00%> (+<0.01%) ⬆️
src/utils/validateUtil.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e16877...2f75e5d. Read the comment docs.

@zombieJ zombieJ changed the title [WIP] feat: rules support warningOnly feat: rules support warningOnly Jun 1, 2021
@crazyair
Copy link
Contributor

crazyair commented Jun 2, 2021

到 ant-design 了,warning 需要黄色显示吗?

@zombieJ
Copy link
Member Author

zombieJ commented Jun 2, 2021

到 ant-design 了,warning 需要黄色显示吗?

嗯,现在 antd 有 warning 类型。但是需要手工设置,底层支持后就可以自动切 warning 状态了。

@zombieJ zombieJ merged commit 7a3c7f2 into master Jun 2, 2021
@delete-merged-branch delete-merged-branch bot deleted the warning branch June 2, 2021 02:09
zombieJ added a commit that referenced this pull request Jun 2, 2021
* 1.20.1

* feat: Support onError event

* fix: Every update errors should trigger event

* test: Test driven of onError

* feat: All message support variable

* fix: Fill template logic

* feat: support warning

* test: Test driven

* chore: export getFieldWarning

* fix: summary validate logic

* test: Update coverage

* test: Update coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants