Skip to content

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jun 11, 2019

  • Support global validateMessages config.
  • Support communication between forms.

Preview

📸 Context Demo

Document

📖 https://github.com/react-component/field-form/blob/context/README.md#formprovider

@vercel
Copy link

vercel bot commented Jun 11, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://rc-field-form-git-context.react-component.now.sh

@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #4 into master will increase coverage by 0.44%.
The diff coverage is 46.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
+ Coverage   16.27%   16.72%   +0.44%     
==========================================
  Files          11       13       +2     
  Lines         590      616      +26     
  Branches       99      110      +11     
==========================================
+ Hits           96      103       +7     
- Misses        494      510      +16     
- Partials        0        3       +3
Impacted Files Coverage Δ
src/useForm.ts 24.51% <0%> (ø) ⬆️
src/index.tsx 100% <100%> (+31.42%) ⬆️
src/FormContext.tsx 16.66% <16.66%> (ø)
src/Form.tsx 59.45% <59.45%> (ø)
src/Field.tsx 1.45% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b858f93...76db5a0. Read the comment docs.

@zombieJ
Copy link
Member Author

zombieJ commented Jun 11, 2019

Please feel free if current context api design should update. @afc163

<Form1 />
<Form2 />
</div>
</FormProvider>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule 我们现在是 Field level 的,不太好支持。

@zombieJ zombieJ marked this pull request as ready for review June 12, 2019 06:35
@zombieJ zombieJ merged commit d465376 into master Jun 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the context branch June 12, 2019 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants