Skip to content

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jun 12, 2019

  • Customize validator support promise
  • Warning if use callback or not return promise
  • Add related test case

Preview

🐒 StateForm-validate-perf

@codecov
Copy link

codecov bot commented Jun 12, 2019

Codecov Report

Merging #5 into master will increase coverage by 52.53%.
The diff coverage is 95.65%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #5       +/-   ##
===========================================
+ Coverage   16.72%   69.25%   +52.53%     
===========================================
  Files          13       13               
  Lines         616      631       +15     
  Branches      110      110               
===========================================
+ Hits          103      437      +334     
+ Misses        510      193      -317     
+ Partials        3        1        -2
Impacted Files Coverage Δ
src/useForm.ts 65.38% <0%> (+40.86%) ⬆️
src/utils/validateUtil.ts 97.5% <100%> (+91.34%) ⬆️
src/Form.tsx 67.56% <0%> (+8.1%) ⬆️
src/utils/valueUtil.ts 56.14% <0%> (+42.1%) ⬆️
src/utils/NameMap.ts 51.72% <0%> (+48.27%) ⬆️
src/FormContext.tsx 72.22% <0%> (+55.55%) ⬆️
src/utils/typeUtil.ts 75% <0%> (+75%) ⬆️
src/Field.tsx 77.37% <0%> (+75.91%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d465376...ee78075. Read the comment docs.

@vercel
Copy link

vercel bot commented Jun 12, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://rc-field-form-git-promise.react-component.now.sh

@zombieJ zombieJ requested a review from afc163 June 12, 2019 09:50
@zombieJ
Copy link
Member Author

zombieJ commented Jun 12, 2019

OK to merge?

@zombieJ zombieJ merged commit dfc4a0f into master Jun 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the promise branch June 12, 2019 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants