Skip to content

Conversation

picodoth
Copy link
Contributor

addressing #168

@picodoth picodoth requested a review from yesmeck July 13, 2018 07:50
@coveralls
Copy link

coveralls commented Jul 13, 2018

Coverage Status

Coverage remained the same at 99.676% when pulling 72e2558 on customize-divider-style into 1421abe on master.

@yesmeck
Copy link
Member

yesmeck commented Jul 13, 2018

propTypes

默认值最好改成 defaultProps

@picodoth picodoth force-pushed the customize-divider-style branch from 9d427fa to 87a72cd Compare July 13, 2018 08:10
src/Divider.jsx Outdated
Divider.defaultProps = {
className: '',
style: {},
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

menu/src/Divider.jsx

Lines 5 to 13 in 87a72cd

static propTypes = {
className: PropTypes.string,
rootPrefixCls: PropTypes.string,
};
static defaultProps = {
// To fix keyboard UX.
disabled: true,
};

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yesmeck disabled 还需要么?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有用的 7dfd303

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我也觉得有用,可是奇怪的是 divider 里都没引用这个 props

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个地方我不敢乱改。。。照道理 直接
render() => { render (<li disabled>...</li>); }
不过 disabled attribute 在 li 上没定义啊

@picodoth picodoth force-pushed the customize-divider-style branch 2 times, most recently from 72e2558 to b3836dc Compare July 13, 2018 12:31
@picodoth picodoth force-pushed the customize-divider-style branch from b3836dc to 6823ebb Compare July 13, 2018 12:32
@picodoth picodoth merged commit 0efef0b into master Jul 14, 2018
@picodoth picodoth deleted the customize-divider-style branch July 14, 2018 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants