Skip to content

Redo overflow #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 30, 2018
Merged

Redo overflow #180

merged 13 commits into from
Aug 30, 2018

Conversation

picodoth
Copy link
Contributor

todo item: try not to apply overflow: hidden on root menu.

@picodoth picodoth mentioned this pull request Jul 18, 2018
Closed
@coveralls
Copy link

coveralls commented Jul 18, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.7%) to 98.956% when pulling 5868f06 on redo-overflow into b93a156 on master.

@picodoth
Copy link
Contributor Author

@yesmeck @afc163
我把不需要设置 menu root 为 relative 改好了，关于 不用resize handler 而用 observer 我在想:

  1. 必要性？
  2. 如果确实必要，是不是可以考虑放另一个 pr，要不我真怕时间比较紧张

@picodoth picodoth requested review from yesmeck and afc163 July 30, 2018 03:37
@afc163 afc163 requested a review from zombieJ July 30, 2018 08:10
@zombieJ
Copy link
Member

zombieJ commented Jul 30, 2018 •
edited
Loading

overflowedIndicator={false} 的时候占位 li 还是在的?
哦，好像不能 false

@picodoth
Copy link
Contributor Author

picodoth commented Aug 4, 2018

@yesmeck 我试了一下 mutation observer， 但是好像 jest �跑起来有问题，有没有碰到类似的情况

@ant-design-bot
Copy link

ant-design-bot commented Aug 19, 2018 •
edited
Loading

Deploy preview for rc-menu ready!

Built with commit 5868f06

https://deploy-preview-180--rc-menu.netlify.com

@picodoth picodoth changed the title [WIP]Redo overflow Redo overflow Aug 19, 2018
@picodoth
Copy link
Contributor Author

用了 ResizeObserver 和 MutationObserver.

ResizeObserver => 监控子元素宽度变化
MutationObserver => 监控子元素增加或者减少

@picodoth picodoth force-pushed the redo-overflow branch 2 times, most recently from 54fb52c to f4076bf Compare August 19, 2018 10:21
@picodoth
Copy link
Contributor Author

picodoth commented Aug 19, 2018 •
edited
Loading

Ready for another round

@chenshuai2144
Copy link
Contributor

感觉这波很稳呀

@picodoth picodoth merged commit bf86e44 into master Aug 30, 2018
@picodoth picodoth deleted the redo-overflow branch August 30, 2018 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesmeck yesmeck Awaiting requested review from yesmeck

@afc163 afc163 Awaiting requested review from afc163

@zombieJ zombieJ Awaiting requested review from zombieJ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@picodoth @coveralls @zombieJ @ant-design-bot @chenshuai2144