Skip to content

feat: make Notification.newInstance to return a Promise, close: #21 #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2017
Merged

feat: make Notification.newInstance to return a Promise, close: #21 #27

merged 1 commit into from
Oct 10, 2017

Conversation

benjycui
Copy link
Member

Close: #21

@benjycui benjycui requested review from afc163 and paranoidjk October 10, 2017 02:40
@benjycui benjycui mentioned this pull request Oct 10, 2017
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 71e2823 on feat-react@16 into 3d1d2b7 on master.

@benjycui benjycui changed the title feat: make Notification.newInstance to return a Promise, close: #21 [WIP] feat: make Notification.newInstance to return a Promise, close: #21 Oct 10, 2017
@benjycui
Copy link
Member Author

先改为 callback，用 Promise 的话在 IE 需要 polyfill

@benjycui benjycui changed the title [WIP] feat: make Notification.newInstance to return a Promise, close: #21 feat: make Notification.newInstance to return a Promise, close: #21 Oct 10, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ca2a128 on feat-react@16 into 3d1d2b7 on master.

@benjycui benjycui merged commit 4b44f2e into master Oct 10, 2017
@benjycui benjycui deleted the feat-react@16 branch October 10, 2017 07:13
@benjycui
Copy link
Member Author

3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afc163 afc163 afc163 approved these changes

@paranoidjk paranoidjk Awaiting requested review from paranoidjk

Assignees

@afc163 afc163

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@benjycui @coveralls @afc163