Skip to content

Conversation

DylanVann
Copy link
Contributor

@DylanVann DylanVann commented Jan 3, 2019

Rebase of: #43

Passes data-, aria-, and role props to Notice to render as html attributes.

@ant-design-bot
Copy link

Deploy preview for rc-notification failed.

Built with commit 69882b1

https://app.netlify.com/sites/rc-notification/deploys/5c2e99a17b6b4f0009008a08

@afc163
Copy link
Member

afc163 commented Dec 30, 2019

conflicted

@afc163
Copy link
Member

afc163 commented Mar 10, 2020

Could u fix conflicting files?

@DylanVann
Copy link
Contributor Author

@afc163 Sorry I didn't see your earlier message. Conflicts are resolved.

@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

Merging #54 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   99.18%   99.21%   +0.03%     
==========================================
  Files           3        3              
  Lines         123      128       +5     
  Branches       23       24       +1     
==========================================
+ Hits          122      127       +5     
  Misses          1        1              
Impacted Files Coverage Δ
src/Notification.tsx 100.00% <ø> (ø)
src/Notice.tsx 97.56% <100.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e28162...fb3269c. Read the comment docs.

@vercel
Copy link

vercel bot commented Mar 10, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/react-component/notification/43a4jbcyn
✅ Preview: https://notification-git-fork-dylanvann-data-attributes.react-component.now.sh

@vercel vercel bot temporarily deployed to Preview March 19, 2020 18:45 Inactive
@vercel vercel bot temporarily deployed to Preview March 19, 2020 18:49 Inactive
@vercel vercel bot temporarily deployed to Preview March 19, 2020 18:50 Inactive
@DylanVann DylanVann changed the title render aria and data props as attributes feat: Render aria and data props Mar 19, 2020
@afc163 afc163 merged commit 7d0aed0 into react-component:master Apr 10, 2020
@afc163
Copy link
Member

afc163 commented Apr 10, 2020

There are some typescript errors: https://travis-ci.org/github/react-component/notification/jobs/673470049

Could you help to fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants