-
Notifications
You must be signed in to change notification settings - Fork 116
feat: Render aria and data props #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploy preview for rc-notification failed. Built with commit 69882b1 https://app.netlify.com/sites/rc-notification/deploys/5c2e99a17b6b4f0009008a08 |
conflicted |
Could u fix conflicting files? |
69882b1
to
0b61ec9
Compare
@afc163 Sorry I didn't see your earlier message. Conflicts are resolved. |
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
+ Coverage 99.18% 99.21% +0.03%
==========================================
Files 3 3
Lines 123 128 +5
Branches 23 24 +1
==========================================
+ Hits 122 127 +5
Misses 1 1
Continue to review full report at Codecov.
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/react-component/notification/43a4jbcyn |
28b6e70
to
fb3269c
Compare
There are some typescript errors: https://travis-ci.org/github/react-component/notification/jobs/673470049 Could you help to fix it? |
Rebase of: #43
Passes data-, aria-, and role props to Notice to render as html attributes.