-
Notifications
You must be signed in to change notification settings - Fork 37
fix: do not use useLayoutEffect if not on client #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix: import error fix: reset indent
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/react-component/overflow/6DAjFbqGmRNgHL6t2KSms3pisp5j |
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
===========================================
- Coverage 100.00% 99.50% -0.50%
===========================================
Files 4 5 +1
Lines 200 204 +4
Branches 62 64 +2
===========================================
+ Hits 200 203 +3
- Misses 0 1 +1
Continue to review full report at Codecov.
|
I am not certain if this is test-able while the JSDom is enabled in Jest. 😞 The same thing happened in react-component/select where the line is ignored by test coverage. See this line. I could be wrong with this, but I do not have enough experience in testing |
I would ignore it like we do on |
Should I add the comment which will tell the test coverage to ignore the line, just like how react-component/select did? |
Fixes #6