Skip to content

perf: uninstall classnames, install clsx #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2025
Merged

perf: uninstall classnames, install clsx #659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
},
"dependencies": {
"@rc-component/util": "^1.3.0",
"classnames": "^2.3.2"
"clsx": "^2.1.1"
},
"devDependencies": {
"@rc-component/father-plugin": "^2.0.2",
Expand All @@ -52,6 +52,7 @@
"@testing-library/react": "^16.0.1",
"@testing-library/user-event": "^14.5.2",
"@types/jest": "^29.2.2",
"@types/node": "^24.5.2",
"@types/react": "^19.0.8",
"@types/react-dom": "^19.0.3",
"@umijs/fabric": "^4.0.1",
Expand Down
4 changes: 2 additions & 2 deletions src/Pager.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* eslint react/prop-types: 0 */
import classNames from 'classnames';
import { clsx } from 'clsx';
import React from 'react';
import type { PaginationProps } from './interface';

Expand Down Expand Up @@ -32,7 +32,7 @@ const Pager: React.FC<PagerProps> = (props) => {
} = props;
const prefixCls = `${rootPrefixCls}-item`;

const cls = classNames(
const cls = clsx(
prefixCls,
`${prefixCls}-${page}`,
{
Expand Down
16 changes: 8 additions & 8 deletions src/Pagination.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import classNames from 'classnames';
import { clsx } from 'clsx';
import useControlledState from '@rc-component/util/lib/hooks/useControlledState';
import KeyCode from '@rc-component/util/lib/KeyCode';
import pickAttrs from '@rc-component/util/lib/pickAttrs';
Expand Down Expand Up @@ -446,7 +446,7 @@ const Pagination: React.FC<PaginationProps> = (props) => {
onClick={jumpPrevHandle}
tabIndex={0}
onKeyDown={runIfEnterJumpPrev}
className={classNames(`${prefixCls}-jump-prev`, {
className={clsx(`${prefixCls}-jump-prev`, {
[`${prefixCls}-jump-prev-custom-icon`]: !!jumpPrevIcon,
})}
>
Expand All @@ -461,7 +461,7 @@ const Pagination: React.FC<PaginationProps> = (props) => {
onClick={jumpNextHandle}
tabIndex={0}
onKeyDown={runIfEnterJumpNext}
className={classNames(`${prefixCls}-jump-next`, {
className={clsx(`${prefixCls}-jump-next`, {
[`${prefixCls}-jump-next-custom-icon`]: !!jumpNextIcon,
})}
>
Expand All @@ -488,7 +488,7 @@ const Pagination: React.FC<PaginationProps> = (props) => {

if (current - 1 >= pageBufferSize * 2 && current !== 1 + 2) {
pagerList[0] = React.cloneElement<PagerProps>(pagerList[0], {
className: classNames(
className: clsx(
`${prefixCls}-item-after-jump-prev`,
pagerList[0].props.className,
),
Expand All @@ -500,7 +500,7 @@ const Pagination: React.FC<PaginationProps> = (props) => {
if (allPages - current >= pageBufferSize * 2 && current !== allPages - 2) {
const lastOne = pagerList[pagerList.length - 1];
pagerList[pagerList.length - 1] = React.cloneElement(lastOne, {
className: classNames(
className: clsx(
`${prefixCls}-item-before-jump-next`,
lastOne.props.className,
),
Expand All @@ -526,7 +526,7 @@ const Pagination: React.FC<PaginationProps> = (props) => {
onClick={prevHandle}
tabIndex={prevDisabled ? null : 0}
onKeyDown={runIfEnterPrev}
className={classNames(`${prefixCls}-prev`, paginationClassNames?.item, {
className={clsx(`${prefixCls}-prev`, paginationClassNames?.item, {
[`${prefixCls}-disabled`]: prevDisabled,
})}
style={styles?.item}
Expand Down Expand Up @@ -555,7 +555,7 @@ const Pagination: React.FC<PaginationProps> = (props) => {
onClick={nextHandle}
tabIndex={nextTabIndex}
onKeyDown={runIfEnterNext}
className={classNames(`${prefixCls}-next`, paginationClassNames?.item, {
className={clsx(`${prefixCls}-next`, paginationClassNames?.item, {
[`${prefixCls}-disabled`]: nextDisabled,
})}
style={styles?.item}
Expand All @@ -566,7 +566,7 @@ const Pagination: React.FC<PaginationProps> = (props) => {
);
}

const cls = classNames(prefixCls, className, {
const cls = clsx(prefixCls, className, {
[`${prefixCls}-start`]: align === 'start',
[`${prefixCls}-center`]: align === 'center',
[`${prefixCls}-end`]: align === 'end',
Expand Down