Skip to content

fix: hide warning while no formatText is given #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 8, 2020
Merged

fix: hide warning while no formatText is given #102

merged 5 commits into from
Jul 8, 2020

Conversation

iamkun
Copy link
Collaborator

@iamkun iamkun commented Jul 8, 2020

@vercel
Copy link

vercel bot commented Jul 8, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/picker/izevmh10u
✅ Preview: https://picker-git-fork-iamkun-patch-1.react-component.vercel.app

@vercel vercel bot requested a deployment to Preview July 8, 2020 06:33 Abandoned
@iamkun iamkun mentioned this pull request Jul 8, 2020
Closed
1 task
afc163
afc163 reviewed Jul 8, 2020
View reviewed changes
@iamkun @afc163
Update src/generate/dayjs.ts
e7f4a67 
Co-authored-by: 偏右 <afc163@gmail.com>
@vercel vercel bot temporarily deployed to Preview July 8, 2020 06:58 Inactive
@vercel vercel bot temporarily deployed to Preview July 8, 2020 06:59 Inactive
@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #102 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #102   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files          43       43           
  Lines        1900     1901    +1     
  Branches      569      577    +8     
=======================================
+ Hits         1892     1893    +1     
  Misses          6        6           
  Partials        2        2
Impacted Files Coverage Δ
src/generate/dayjs.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b5a239...44386b0. Read the comment docs.

@zombieJ zombieJ merged commit 1f0d9d0 into react-component:master Jul 8, 2020
zombieJ pushed a commit that referenced this pull request Jul 8, 2020
@iamkun @afc163 @zombieJ
fix: hide warning while no formatText is given (#102)
f68bd26 
* fix: hide warning while no formatText is given

* Update src/generate/dayjs.ts

Co-authored-by: 偏右 <afc163@gmail.com>

* Update dayjs.ts

* Update dayjs.ts

* Update dayjs.ts

Co-authored-by: 偏右 <afc163@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 afc163 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Receiving a Warning Note when using Dayjs with DatePicker
3 participants
@iamkun @afc163 @zombieJ