Skip to content

Conversation

kerm1it
Copy link
Member

@kerm1it kerm1it commented Jul 24, 2020

@vercel
Copy link

vercel bot commented Jul 24, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/picker/j8xi3koru
✅ Preview: https://picker-git-fork-kermit-xuan-fix-25746.react-component.vercel.app

@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #108 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #108   +/-   ##
=======================================
  Coverage   99.58%   99.58%           
=======================================
  Files          44       44           
  Lines        1920     1922    +2     
  Branches      575      585   +10     
=======================================
+ Hits         1912     1914    +2     
  Misses          6        6           
  Partials        2        2           
Impacted Files Coverage Δ
src/RangePicker.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1a20a8...dd40ea6. Read the comment docs.

@kerm1it
Copy link
Member Author

kerm1it commented Jul 24, 2020

@zombieJ

@hoho2017
Copy link

hoho2017 commented Jul 24, 2020

it's still work when user choose this moment
image

@kerm1it
Copy link
Member Author

kerm1it commented Jul 24, 2020

I notice this problem, but it's different from the confirmation button.

Because the 'now' is dynamic, we don't know whether it's disabled when opening panel. It's only confirmed when the user clicks the now button.

Therefore, we can make the click have no effect when clicking the now button.

@hoho2017
Copy link

I notice this problem, but it's different from the confirmation button.

Because the 'now' is dynamic, we don't know whether it's disabled when opening panel. It's only confirmed when the user clicks the now button.

Therefore, we can make the click have no effect when clicking the now button.

Can we check the input value when the choos time tab hid~~

@kerm1it
Copy link
Member Author

kerm1it commented Jul 24, 2020

I notice this problem, but it's different from the confirmation button.
Because the 'now' is dynamic, we don't know whether it's disabled when opening panel. It's only confirmed when the user clicks the now button.
Therefore, we can make the click have no effect when clicking the now button.

Can we check the input value when the choos time tab hid~~

We can don't submit it if the result of disabledTime is true when the user clicks now button

But we can't disable the now button when open panel.

@hoho2017
Copy link

I notice this problem, but it's different from the confirmation button.
Because the 'now' is dynamic, we don't know whether it's disabled when opening panel. It's only confirmed when the user clicks the now button.
Therefore, we can make the click have no effect when clicking the now button.

Can we check the input value when the choos time tab hid~~

We can don't submit it if the result of disabledTime is true when the user clicks now button

But we can't disable the now button when open panel.

i know we can't submit it but if we remove the disabledTime value will be better^^

@zombieJ zombieJ merged commit 37b240b into react-component:master Jul 25, 2020
@zombieJ
Copy link
Member

zombieJ commented Jul 25, 2020

+ rc-picker@1.13.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants