Skip to content

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Feb 3, 2020

@vercel
Copy link

vercel bot commented Feb 3, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/react-component/picker/fgpczo46j
✅ Preview: https://picker-git-fix-defaultopenvalue.react-component.now.sh

@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #23 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage   99.19%   99.19%   +<.01%     
==========================================
  Files          39       39              
  Lines        1730     1736       +6     
  Branches      526      528       +2     
==========================================
+ Hits         1716     1722       +6     
  Misses          9        9              
  Partials        5        5
Impacted Files Coverage Δ
src/PanelContext.tsx 100% <ø> (ø) ⬆️
src/PickerPanel.tsx 100% <100%> (ø) ⬆️
src/Picker.tsx 99.07% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9b7a6e...a20aae0. Read the comment docs.

@zombieJ zombieJ merged commit 76e7c37 into master Feb 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-defaultOpenValue branch February 3, 2020 10:05
extends PickerSharedProps<DateType>,
Omit<OmitPanelProps<PickerPanelTimeProps<DateType>>, 'format'> {}
Omit<OmitPanelProps<PickerPanelTimeProps<DateType>>, 'format'> {
picker: 'time';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

picker : 'time' 写错了吧?

文档里里 date | week | month | quarter | year

下面代码给的默认值是 picker = 'date'

而且picker应该是optional的。这里导致了一个issue:
ant-design/ant-design#22955

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants