Skip to content

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 6, 2020

@vercel
Copy link

vercel bot commented Mar 6, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/react-component/picker/5r586auv3
✅ Preview: https://picker-git-time-range-no-order.react-component.now.sh

@codecov
Copy link

codecov bot commented Mar 6, 2020

Codecov Report

Merging #33 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
- Coverage    99.2%   99.19%   -0.01%     
==========================================
  Files          39       39              
  Lines        1762     1741      -21     
  Branches      530      513      -17     
==========================================
- Hits         1748     1727      -21     
  Misses          9        9              
  Partials        5        5
Impacted Files Coverage Δ
src/RangePicker.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdcbae8...fe980d4. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Mar 6, 2020

是不是加个属性,避免有些场景下不希望倒序。

@zombieJ
Copy link
Member Author

zombieJ commented Mar 6, 2020

reorder 如何?默认为 true

@afc163
Copy link
Member

afc163 commented Mar 6, 2020

keepOrder ?

@afc163
Copy link
Member

afc163 commented Mar 6, 2020

或者 allowReverse

@zombieJ
Copy link
Member Author

zombieJ commented Mar 6, 2020

直接 order 吧,allowReverse 感觉会有设置了可以有个按钮点击翻转的感觉(allowClear)。

@vercel vercel bot temporarily deployed to Preview March 6, 2020 08:33 Inactive
@zombieJ
Copy link
Member Author

zombieJ commented Mar 6, 2020

添加 order 属性,默认为 true

@zombieJ zombieJ merged commit 632a1e3 into master Mar 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the time-range-no-order branch March 6, 2020 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TimePicker.RangePicker automaticlly sort values
2 participants