Skip to content

fix: should not action when RangePicker set disabled #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2023
Merged

fix: should not action when RangePicker set disabled #659

merged 1 commit into from
Jul 25, 2023

Conversation

wongest
Copy link
Contributor

@wongest wongest commented Jul 24, 2023

@vercel
Copy link

vercel bot commented Jul 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
picker ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2023 3:13am

@wongest wongest force-pushed the fix/20230624_hmq branch from 666f5db to 6c2785e Compare July 25, 2023 02:11
@wongest wongest changed the title fix: should not ation when RangePicker set disabled fix: should not action when RangePicker set disabled Jul 25, 2023
@wongest wongest force-pushed the fix/20230624_hmq branch from 6c2785e to 9bca4ad Compare July 25, 2023 03:11
@wongest wongest mentioned this pull request Jul 25, 2023
Closed
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #659 (0290c45) into master (f699375) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 0290c45 differs from pull request most recent head 9bca4ad. Consider uploading reports for the commit 9bca4ad to get more accurate results

@@           Coverage Diff           @@
##           master     #659   +/-   ##
=======================================
  Coverage   99.04%   99.04%           
=======================================
  Files          55       55           
  Lines        2416     2416           
  Branches      716      716           
=======================================
  Hits         2393     2393           
  Misses         21       21           
  Partials        2        2
Files Changed Coverage Δ
src/RangePicker.tsx 99.27% <ø> (ø)
src/hooks/useRangeOpen.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

yoyo837
yoyo837 approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@yoyo837 yoyo837 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yoyo837 yoyo837 requested a review from zombieJ July 25, 2023 03:42
@MadCcc MadCcc merged commit 684467d into react-component:master Jul 25, 2023
@Hcy2ly
Copy link

Hcy2ly commented Jul 25, 2023

大佬们 大概啥时候发新版本呀

@yoyo837
Copy link
Member

yoyo837 commented Jul 25, 2023

大佬们 大概啥时候发新版本呀

https://github.com/react-component/picker/releases/tag/v3.11.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yoyo837 yoyo837 yoyo837 approved these changes

@MadCcc MadCcc MadCcc approved these changes

@zombieJ zombieJ Awaiting requested review from zombieJ

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

4 participants

@wongest @Hcy2ly @yoyo837 @MadCcc