Skip to content

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented May 19, 2020

做成了一个 object 免得未来还有需要拓展。另外帮忙看一下名字:

export type RangeDateRender<DateType> = (
  currentDate: DateType,
  today: DateType,
  info: {
    range: 'start' | 'end';
  },
) => React.ReactNode;

position 在内部是双面板时区分左右用的,免得未来拓展搞迷糊就没用这个名字用了 range,帮忙看看有没有更好的命名。

ref: ant-design/ant-design#24124 (comment)

@zombieJ zombieJ requested review from afc163 and shaodahong May 19, 2020 03:53
@codecov
Copy link

codecov bot commented May 19, 2020

Codecov Report

Merging #74 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #74   +/-   ##
=======================================
  Coverage   99.55%   99.55%           
=======================================
  Files          43       43           
  Lines        1788     1793    +5     
  Branches      531      534    +3     
=======================================
+ Hits         1780     1785    +5     
  Misses          6        6           
  Partials        2        2           
Impacted Files Coverage Δ
src/RangePicker.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d94a4d...579ed3b. Read the comment docs.

Copy link
Member

@shaodahong shaodahong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我一开始的想法也是扩展成对象,不然后面扩展拉面条一样,命名 range 可以

@zombieJ zombieJ merged commit bd96283 into master May 19, 2020
@delete-merged-branch delete-merged-branch bot deleted the RangePicker-render branch May 19, 2020 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants