fix: icons in month and quarter #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
这里实际上是 |
|
这里与之类似的是 |
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
=======================================
Coverage 99.55% 99.55%
=======================================
Files 42 42
Lines 1792 1792
Branches 529 529
=======================================
Hits 1784 1784
Misses 6 6
Partials 2 2
Continue to review full report at Codecov.
|
|
上面两张图是这个button这里的比较图。 |
|
顺便问一下这三个picker里面的这个key是不是应该不相同= = |
|
ok,done了 |
xrkffgg
approved these changes
Jun 16, 2020
xrkffgg
changed the title
|
我想不起来为什么要写 key 了，看起来这里的 key 是可以删掉的？没用就删了吧。 |
|
已删~ |
|
Year 那个是不是也可以删了？其他地方有用到这个没用的 key 都可以顺道清理一下哈~ |
|
ok,刚才删了，忘了push上来。。。。已经都删了 |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relative issue: ant-design/ant-design#24937