Skip to content

strokeLinecap default should be 'butt' #14

@codemonkeynorth

Description

@codemonkeynorth

'butt' is the default, but your default is 'round' and 'butt' is excluded from the options

see:
https://css-tricks.com/almanac/properties/s/stroke-linecap/

therefore
https://github.com/react-component/progress/blob/2.0.3/src/mixin.js#L10
should presumably be eg
strokeLinecap: PropTypes.oneOf(['butt', 'round', 'square']),

and
https://github.com/react-component/progress/blob/2.0.3/src/mixin.js#L21
should be
strokeLinecap: 'butt',

thanks

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions