实现半圆 #20
Merged
实现半圆 #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
增加了太多属性了。
应该就足够了。 |
|
@afc163 也可以，让使用者自己将值转换为百分比。我修改一下 |
|
@afc163 已经删除了remove value, minValue, MaxValue，只保留了gapWidth和gapPosition |
|
ci的环境好像不支持ES6的一些写法，检查失败了。 |
|
Line 11 in 725f238 改为 6 即可。 |
|
补个用例？ |
benjycui
reviewed
Mar 16, 2017
| <td>gapWidth</td> | ||
| <td>Number</td> | ||
| <td>0</td> | ||
| <td>the gap width of half circle</td> |
There was a problem hiding this comment.
其实这个我是有点困惑的，是按百分比还是绝对值？绝对值的话，宽度又是相对于什么？
benjycui
reviewed
Mar 16, 2017
HISTORY.md
Outdated
| --- | ||
|
|
||
| ## 2.1.0 | ||
| - Add `value` `minValue` `maxValue` `openWidth` `beginPosition` props. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
增加了属性：
value： 如果设置将会覆盖percent， 如果不设置就是要percent；minValue: 进度的起点值，例如温度仪表盘，起点不一定是0，这个值缺省0；maxValue：进度的终点值，缺省100openWidth：半圆开口的宽度，缺省0beginPosition：进度起始位置，更重要的是影响半圆开口方向，目前设置了上下左右四个方向，值为：'top', 'bottom', 'left', 'right'，缺省向上，保持和以前相同。这部分修改不影响之前的功能。