Fix server side rendering #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The remaining lint errors are in the examples which I did not modify. The issue is "Declare only one React component per file react/no-multi-comp" and to solve it, the examples would need to be properly refactored, so I think this is beyond the scope of this fix. As for the reduced coverage, since the fix is dealing with server side rendering, there is no way I can write a browser test to test server side render. |
afc163
added a commit
that referenced
this pull request
Jan 13, 2016
|
Thx for your contribution!!! I fixed the lint problems and the coverage issue does not matter for this. |
|
0.11.4 bumped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require velocity only on client, make a stub on server.
This fixed most if not all issues with ant-design components not working on a project that does server side rendering.