feat: support htmlTitle for label #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview 4d62801 has been successfully built and deployed to https://react-component-segmented-preview-pr-19.surge.sh 🕐 Build time: 154.176s
🤖 By surge-preview |
afc163
reviewed
Mar 28, 2022
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 65 72 +7
Branches 12 13 +1
=========================================
+ Hits 65 72 +7
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
选择系列的组件直接就叫 |
zombieJ
reviewed
Mar 29, 2022
src/index.tsx
Outdated
| @@ -33,13 +37,31 @@ export interface SegmentedProps extends React.HTMLProps<HTMLDivElement> { | |||
| motionName?: string; | |||
| } | |||
|
|
|||
| function getValidHtmlTitle(option: SegmentedLabeledOption) { | |||
There was a problem hiding this comment.
感觉还可以再抽一个 getValid 判断 string 和 number 然后直接 return getValid(option.title) ?? getValid(option.label)
There was a problem hiding this comment.
目前看起来这个判断是够用的，后面我考虑下，因为 title 其实要求是 string，而 label 其实在 options 下也应该要求是 string 才好，但是现在 label 是 ReactNode 所以这个判断处理起来有点怪，你可以看看新的写法
zombieJ
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
规则
增加 title(html title) 属性