onChange callback will also pass `option` param #157

RaoHai · 2017-01-17T05:21:32Z

close 建议 Select 选择器的 onChange 函数增加 option 参数方便回调 ant-design/ant-design#4597
onChange(value, option: Option | Array)

* cherry-pick * remove useless files * remove useless files * Group ts * update interface * ReactElement

coveralls · 2017-01-17T12:37:01Z

Changes Unknown when pulling 17a3bd3 on RaoHai:onChangeOption into ** on react-component:master**.

coveralls · 2017-01-18T02:35:34Z

Changes Unknown when pulling c2fcfbb on RaoHai:onChangeOption into ** on react-component:master**.

coveralls · 2017-01-18T02:37:19Z

Changes Unknown when pulling c2fcfbb on RaoHai:onChangeOption into ** on react-component:master**.

RaoHai · 2017-01-19T09:54:11Z

@yiminghe @yesmeck review 下。。

yesmeck · 2017-01-19T09:58:47Z

README.md

@@ -89,7 +89,7 @@ React.render(c, container);
 |defaultValue | initial selected option(s) | String/Array<String> | - |
 |value | current selected option(s) | String/Array<String>/{key:String, label:React.Node}/Array<{key, label}> | - |
 |labelInValue| whether to embed label in value, see above value type | Bool | false |
-|onChange | called when select an option or input value change(combobox) | function(value) | - |
+|onChange | called when select an option or input value change(combobox) | function(value, option: Option | Array<Option>) | - |


这个 Option 是指 <Option /> 还是 { key: '1', label: '1' }?

{ key: '1', label: '1' }

issue 里说的应该是 <Option /> 吧，他需要获取 props。

我看一下 onSelect。。。

确实应该是 <Option />

coveralls · 2017-01-20T06:43:42Z

Changes Unknown when pulling e76df9f on RaoHai:onChangeOption into ** on react-component:master**.

RaoHai · 2017-01-20T06:43:49Z

改好了。

现在所有模式都有这个参数，multiple 的时候是数组 Array< <Option/> >，其他时候是 <Option />

yesmeck · 2017-01-22T09:14:14Z

tests/Select.multiple.spec.js

@@ -40,7 +40,7 @@ describe('Select.multiple', () => {
      value: 'One,Two,Three',
    } });

-    expect(handleChange).toBeCalledWith(['1', '2']);
+    expect(handleChange).toBeCalledWith(['1', '2'], [null, null]);


这里不能匹配到 Option 吗？

这个例子有点怪。你自己试试，真实输入 One 是不会出来选项的，要输入 1 才行。但是 test 是通过的，

yesmeck · 2017-01-22T09:15:55Z

src/util.js

@@ -135,3 +135,13 @@ export function splitBySeparators(string, separators) {
  }
  return array;
 }
+
+export function findChildByKey(children, key) {


要考虑 OptGroup 的情况。

yesmeck · 2017-02-16T06:51:51Z

@RaoHai

coveralls · 2017-02-17T09:53:22Z

Changes Unknown when pulling b195636 on RaoHai:onChangeOption into ** on react-component:master**.

coveralls · 2017-02-17T10:10:46Z

Coverage increased (+0.09%) to 95.533% when pulling 9239519 on RaoHai:onChangeOption into 3d7bc35 on react-component:master.

RaoHai · 2017-02-17T10:21:03Z

ci failed...

rc-tools run guard
/home/travis/build/react-component/select/node_modules/rc-tools/lib/gulpfile.js:31
const { tsCompiledDir } = require('./constants');
      ^
SyntaxError: Unexpected token {
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:413:25)
    at Object.Module._extensions..js (module.js:452:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/home/travis/build/react-component/select/node_modules/rc-tools/lib/cli/run.js:31:3)
    at Module._compile (module.js:434:26)
    at Object.Module._extensions..js (module.js:452:10)

yesmeck · 2017-02-17T10:31:34Z

CI 的 node 要换成 6+

…

On Fri, 17 Feb 2017 at 18:21 陆离 ***@***.***> wrote: ci failed... rc-tools run guard /home/travis/build/react-component/select/node_modules/rc-tools/lib/gulpfile.js:31 const { tsCompiledDir } = require('./constants'); — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#157 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAcY5RYTeVlaJrMrX9C84HAxi0NuuD95ks5rdXSPgaJpZM4LlPfm> .

yesmeck · 2017-02-17T11:36:01Z

rebase 下。

+ close ant-design/ant-design#4597 + update document

RaoHai · 2017-02-17T13:40:14Z

为什么出现了两个我。。

yesmeck · 2017-02-17T13:40:58Z

@ @ 还能这样。。。。

coveralls · 2017-02-17T13:42:03Z

Coverage increased (+0.09%) to 95.533% when pulling 5bdc17c on RaoHai:onChangeOption into 2e4b73e on react-component:master.

yesmeck · 2017-02-17T13:42:54Z

你一定用了两个不同的 git user 设置。

RaoHai · 2017-02-17T13:43:47Z

只是换了一台电脑而已。。

yesmeck · 2017-02-17T13:44:52Z

两台电脑上的 git config --get user.email 不一样吧

yesmeck · 2017-02-17T13:45:51Z

哈哈，是 git config --get user.name 不一样。

yesmeck · 2017-02-17T13:47:04Z

afc163 · 2017-02-17T15:20:39Z

看东西重影。

yesmeck · 2017-02-27T08:42:12Z

src/util.js

+export function findChildBy(optionLabelProp, children, key) {
+  let child = null;
+  React.Children.forEach(children, child_ => {
+    if (child_.type === OptGroup) {


用 child_.type.isSelectOptGroup 判断。

yesmeck · 2017-02-27T08:42:48Z

src/util.js

+  React.Children.forEach(children, child_ => {
+    if (child_.type === OptGroup) {
+      child = child || findChildBy(optionLabelProp, child_.props.children, key);
+    } else if (child_.type === Option && (child_.key === key || child_.props.value === key)) {


用 child_.type.isSelectOption 判断

yesmeck · 2017-02-27T08:45:34Z

tests/Select.combobox.spec.js

@@ -38,7 +38,7 @@ describe('Select.combobox', () => {

    wrapper.find('input').simulate('change', { target: { value: '1' } });

-    expect(handleChange).toBeCalledWith('1');
+    expect(handleChange).toBeCalledWith('1', null);


没有 <Option /> 的时候，第二个参数是 null 还是 undefined？我看下面是 undefined。

yutingzhao1991 · 2018-02-02T02:17:05Z

support in #264

afc163 referenced this pull request in ant-design/ant-design Jan 17, 2017

Customize Input Component of AutoComplete (#4483)

46c2008

* cherry-pick * remove useless files * remove useless files * Group ts * update interface * ReactElement

RaoHai force-pushed the onChangeOption branch from c6953a1 to c2fcfbb Compare January 18, 2017 02:33

RaoHai added the enhancement label Jan 19, 2017

yesmeck reviewed Jan 19, 2017

View reviewed changes

yesmeck reviewed Jan 22, 2017

View reviewed changes

afc163 assigned yiminghe Feb 15, 2017

yiminghe assigned yesmeck and unassigned yiminghe Feb 15, 2017

RaoHai force-pushed the onChangeOption branch from b195636 to 9239519 Compare February 17, 2017 10:04

RaoHai added 3 commits February 17, 2017 21:39

onChange callback will also pass option paramt

a08e28a

+ close ant-design/ant-design#4597 + update document

onChange(value, option: Option)

263706a

OptGroup and testCase

5bdc17c

RaoHai force-pushed the onChangeOption branch from 9239519 to 5bdc17c Compare February 17, 2017 13:39

afc163 assigned yesmeck and unassigned yesmeck Feb 27, 2017

yesmeck requested changes Feb 27, 2017

View reviewed changes

yesmeck mentioned this pull request Jan 22, 2018

Support any type value in single and multiple mode #257

Closed

yutingzhao1991 closed this Feb 2, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

onChange callback will also pass `option` param #157

onChange callback will also pass `option` param #157

RaoHai commented Jan 17, 2017 •

edited

Loading

coveralls commented Jan 17, 2017

coveralls commented Jan 18, 2017

coveralls commented Jan 18, 2017

RaoHai commented Jan 19, 2017

yesmeck Jan 19, 2017 •

edited

Loading

RaoHai Jan 20, 2017

yesmeck Jan 20, 2017 •

edited

Loading

RaoHai Jan 20, 2017

RaoHai Jan 20, 2017

coveralls commented Jan 20, 2017

RaoHai commented Jan 20, 2017

yesmeck Jan 22, 2017

RaoHai Feb 17, 2017

yesmeck Jan 22, 2017

yesmeck commented Feb 16, 2017

coveralls commented Feb 17, 2017

coveralls commented Feb 17, 2017

RaoHai commented Feb 17, 2017 •

edited

Loading

yesmeck commented Feb 17, 2017 via email

yesmeck commented Feb 17, 2017

RaoHai commented Feb 17, 2017

yesmeck commented Feb 17, 2017

coveralls commented Feb 17, 2017

yesmeck commented Feb 17, 2017

RaoHai commented Feb 17, 2017

yesmeck commented Feb 17, 2017

yesmeck commented Feb 17, 2017

yesmeck commented Feb 17, 2017

afc163 commented Feb 17, 2017

yesmeck Feb 27, 2017

yesmeck Feb 27, 2017

yesmeck Feb 27, 2017

yutingzhao1991 commented Feb 2, 2018

onChange callback will also pass option param #157

onChange callback will also pass option param #157

Conversation

RaoHai commented Jan 17, 2017 • edited Loading

coveralls commented Jan 17, 2017

coveralls commented Jan 18, 2017

coveralls commented Jan 18, 2017

RaoHai commented Jan 19, 2017

yesmeck Jan 19, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yesmeck Jan 20, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Jan 20, 2017

RaoHai commented Jan 20, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yesmeck commented Feb 16, 2017

coveralls commented Feb 17, 2017

coveralls commented Feb 17, 2017

RaoHai commented Feb 17, 2017 • edited Loading

yesmeck commented Feb 17, 2017 via email

yesmeck commented Feb 17, 2017

RaoHai commented Feb 17, 2017

yesmeck commented Feb 17, 2017

coveralls commented Feb 17, 2017

yesmeck commented Feb 17, 2017

RaoHai commented Feb 17, 2017

yesmeck commented Feb 17, 2017

yesmeck commented Feb 17, 2017

yesmeck commented Feb 17, 2017

afc163 commented Feb 17, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yutingzhao1991 commented Feb 2, 2018

onChange callback will also pass `option` param #157

onChange callback will also pass `option` param #157

RaoHai commented Jan 17, 2017 •

edited

Loading

yesmeck Jan 19, 2017 •

edited

Loading

yesmeck Jan 20, 2017 •

edited

Loading

RaoHai commented Feb 17, 2017 •

edited

Loading