Skip to content

Select won't do anything during Composition #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Select won't do anything during Composition #159

wants to merge 2 commits into from

Conversation

RaoHai
Copy link
Contributor

@RaoHai RaoHai commented Jan 23, 2017

@RaoHai
Copy link
Contributor Author

RaoHai commented Jan 23, 2017

@yesmeck 这个有办法自动测么。。。。

@RaoHai
Copy link
Contributor Author

RaoHai commented Jan 23, 2017 •
edited
Loading

手动跑了 osx / windows 的 chrome / ff / safari 以及 360 之类的浏览器，没发现问题。。 onCompositionStart 和 onCompositionEnd 应该还是可靠的。

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 94.948% when pulling 14fee0c on RaoHai:dumbOnComposition into 58fe745 on react-component:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 94.948% when pulling 14fee0c on RaoHai:dumbOnComposition into 58fe745 on react-component:master.

@RaoHai
Select won't do anything during Composition
9a5a132 
 + close #ant-design/ant-design#4689
 + 新增配置项： dumbOnComposition
 + 为 true 时，输入法弹出时不做任何事情 (onChange, 匹配Option )。直到输入法输入完成后继续。
 + 这个好像没法自动测。。。。
@RaoHai RaoHai force-pushed the dumbOnComposition branch from c126bd6 to 9a5a132 Compare January 23, 2017 04:00
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 94.948% when pulling 9a5a132 on RaoHai:dumbOnComposition into 58fe745 on react-component:master.

@coveralls
Copy link

coveralls commented Jan 23, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.5%) to 94.948% when pulling 7b70f55 on RaoHai:dumbOnComposition into 58fe745 on react-component:master.

@afc163 afc163 mentioned this pull request Jan 23, 2017
Closed
@yiminghe
Copy link
Member

yiminghe commented Feb 3, 2017

wait for facebook/react#3926

@yiminghe yiminghe assigned yesmeck and unassigned yiminghe Feb 16, 2017
@afc163 afc163 assigned yesmeck and unassigned yesmeck Feb 27, 2017
@yesmeck
Copy link
Member

yesmeck commented Apr 2, 2017

不合并的话，先关了。

@yesmeck yesmeck closed this Apr 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yesmeck yesmeck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RaoHai @coveralls @yiminghe @yesmeck