Skip to content

Fire search event only when inputValue changes #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2017
Merged

Fire search event only when inputValue changes #166

merged 1 commit into from
Mar 10, 2017

Conversation

yesmeck
Copy link
Member

@yesmeck yesmeck commented Feb 28, 2017 •
edited
Loading

碰到的问题是，在 input 为空的情况下选择一个选项，这时会同时触发 onSelect 和 onSearch，且 onSearch 得到的参数是个空字符串，这个 onSearch 是多余的。

@yesmeck yesmeck force-pushed the improve-search-event branch from ec13b3c to 361342a Compare February 28, 2017 08:29
@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 95.447% when pulling 361342a on improve-search-event into c60a223 on master.

@yesmeck yesmeck requested review from yiminghe and RaoHai February 28, 2017 09:00
@yesmeck yesmeck mentioned this pull request Feb 28, 2017
Merged
@yiminghe yiminghe removed their request for review March 3, 2017 09:25
@yiminghe
Copy link
Member

yiminghe commented Mar 3, 2017

@RaoHai

@yiminghe yiminghe merged commit 5f43e01 into master Mar 10, 2017
@yiminghe yiminghe deleted the improve-search-event branch March 10, 2017 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaoHai RaoHai Awaiting requested review from RaoHai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yesmeck @coveralls @yiminghe