fix Select[multipie] with OptGroup will cause error. #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yesmeck
requested changes
Apr 2, 2017
| </Select> | ||
| ); | ||
| expect(renderToJson(wrapper)).toMatchSnapshot(); | ||
| expect(errorSpy).not.toHaveBeenCalled(); |
There was a problem hiding this comment.
这个测试写 Select.multipe.spec.js 里就可以了吧，测试是否报错可以用 not.toThrow，没必要 mock console.error 和 snapshot。
There was a problem hiding this comment.
然后这个错误应该是在选择的时候会出现，所以这里要模拟一下选择。tags 模式下也会报错，可以照这样写 https://github.com/react-component/select/blob/master/tests/Select.multiple.spec.js#L12
There was a problem hiding this comment.
错误是初始化时就报的，跟选择行为没啥关系。。。测试写法已更新~
yesmeck
reviewed
Apr 5, 2017
tests/Select.multiple.spec.js
Outdated
| </OptGroup> | ||
| </Select>, | ||
| ); | ||
| }).not.toThrow(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Select[multipie || tags]withOptGroupcan reproducerelervant: ant-design/ant-design#5567