Skip to content

Conversation

lgordey
Copy link

@lgordey lgordey commented Apr 5, 2017

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.734% when pulling 42c9446 on lgordey:master into f74811e on react-component:master.

@RaoHai
Copy link
Contributor

RaoHai commented Apr 7, 2017

@yesmeck

@yesmeck
Copy link
Member

yesmeck commented Apr 7, 2017

The name triggerOnChange is a bit confusing too, <Select triggerOnChange={false} /> makes me think that onChange will never be fired. I think setting flag in onSelect is a acceptable workaround.

@lgordey
Copy link
Author

lgordey commented Apr 7, 2017

@yesmeck in issue there was an option to call it selectTriggersOnChange.
No problem to rename it.

And it will be true by default. So developers will need to redefine it only if necessary.
Most will not even notice, but the mechanics will become more flexible

Setting flag looks like a hack.

@yesmeck
Copy link
Member

yesmeck commented Apr 7, 2017

@RaoHai Can we expose onSearch in AutoComplete? onSearch doesn't fire after onSelect.

@yesmeck
Copy link
Member

yesmeck commented Apr 7, 2017

Oh, onSearch can be used in AutoComplete directly, the only thing need to do is document it in AutoComplete's page.

@lgordey Could you try onSearch to see if it's satisfy your need?

@yesmeck
Copy link
Member

yesmeck commented May 2, 2017

Use onSearch instead of onChange.

@yesmeck yesmeck closed this May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants