Skip to content

Conversation

RaoHai
Copy link
Contributor

@RaoHai RaoHai commented Apr 18, 2017

There's a confusing onFocus flow:

Focus <Select />, onFocus trigger.

  • <Trigger/> focus
  • <div /> focus,
  • onOuterFocus() => props.onFocus() // Select onFocus callback here
  • setPopupVisible() =>Trigger.onPopupVisibleChange() => setOpenState(true)
  • <input /> get focus.

Focus <input />, onFocus not trigger

  • <Trigger /> focus
  • <input /> focus,
  • setPopupVisible() =>Trigger.onPopupVisibleChange() => setOpenState(true)
  • <input /> already focus, do nothing.

@RaoHai RaoHai requested a review from yesmeck April 18, 2017 09:03
@RaoHai RaoHai force-pushed the FocusAndBlurIssues branch from fee6383 to 5f47f8d Compare April 18, 2017 10:55
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 95.254% when pulling 5f47f8d on RaoHai:FocusAndBlurIssues into 7b59a7d on react-component:master.

@yesmeck yesmeck merged commit 93035d4 into react-component:master May 2, 2017
yesmeck added a commit that referenced this pull request May 8, 2017
onFocus will be fired when Dropdown visible change #185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants