Skip to content

Add id for commbobox select #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2017
Merged

Add id for commbobox select #204

merged 1 commit into from
Jun 27, 2017

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jun 26, 2017 

<label htmlFor="xxx">click me</label>
<Select combobox id="xxx" />

1111

写不了用例，enzyme 里没有 label 和 input 的关联效果。

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.585% when pulling 8ea7030 on fix-select-combobox-id into 57f1219 on master.

@yesmeck yesmeck merged commit 42273aa into master Jun 27, 2017
@yesmeck yesmeck deleted the fix-select-combobox-id branch June 27, 2017 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@afc163 @coveralls @yesmeck