Add backfill #218
Merged
Add backfill #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yesmeck
force-pushed
the
backfill
branch
2 times, most recently
from
e7bd182 to
3378d34
Compare
|
依赖 react-component/menu#93 测试才能过。 |
|
普通模式不会回填吗？我看只是改了 placeholder |
|
@jaredleechn 会的，这个 PR 依赖 react-component/menu#93 ，你可以在本地先改下 menu 的代码。 |
|
本地访问 examples 下的 html 返回 Internal Server Error 🤣 |
|
😳 |
afc163
reviewed
Sep 1, 2017
| |value | current selected option(s) | String/Array<String>/{key:String, label:React.Node}/Array<{key, label}> | - | | ||
| |firstActiveValue | first active value when there is no value | String/Array<String> | - | | ||
| |labelInValue| whether to embed label in value, see above value type | Bool | false | | ||
| |backfill| whether backfill select option to search input (Only works in single and combobox mode) | Bool | false | |
There was a problem hiding this comment.
single 模式支持 backfill 感觉没啥意义，只是个展示效果？
afc163
reviewed
Sep 1, 2017
src/Select.jsx
Outdated
| }, 0); | ||
| } | ||
| if (value.length && value[0].key === selectedValue) { | ||
| if (lastValue && lastValue.key === selectedValue && lastValue.backfill !== true) { |
There was a problem hiding this comment.
lastValue.backfill !== true => !lastValue.backfill
afc163
approved these changes
Sep 1, 2017
|
@yesmeck how to disable backfill feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close ant-design/ant-design#5764
single
combobox