Skip to content

Fix clear icon of combobox select #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 27, 2017
Merged

Fix clear icon of combobox select #223

merged 2 commits into from
Oct 27, 2017

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Sep 9, 2017 •
edited
Loading

  • Fix this one:
    xxxx
  • Also set clear icon to null, other than hide it.

@afc163 afc163 requested a review from yesmeck September 9, 2017 07:14
afc163
afc163 commented Sep 9, 2017
View reviewed changes
src/Select.jsx
return clear;
}
return null;
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

主要改动。

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1d668e4 on fix-combobox-clear-icon into a008527 on master.

@yesmeck yesmeck merged commit 0be9750 into master Oct 27, 2017
@yesmeck yesmeck deleted the fix-combobox-clear-icon branch October 27, 2017 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesmeck yesmeck Awaiting requested review from yesmeck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@afc163 @coveralls @yesmeck