Skip to content

Allow any option value in single or multiple mode #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Allow any option value in single or multiple mode #228

wants to merge 1 commit into from

Conversation

yesmeck
Copy link
Member

@yesmeck yesmeck commented Sep 27, 2017

@yesmeck yesmeck force-pushed the option-any-value branch 2 times, most recently from 8083fff to 3e29c29 Compare September 27, 2017 08:52
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling cc4c7a4 on option-any-value into 5eae362 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling cc4c7a4 on option-any-value into 5eae362 on master.

@yesmeck
Copy link
Member Author

yesmeck commented Sep 27, 2017

object value cause too many problems, for example

<Option value={{ id: 1 }}>Lucy</Option>
<Option value={{ id: 2 }}>Jack</Option>

renders to:

<MenuItem key="[Object object]">Lucy</MenuItem>
<MenuItem key="[Object object]">Jack</MenuItem>

which leads key conflict.

@yesmeck
Copy link
Member Author

yesmeck commented Sep 27, 2017

Closing since it's hard to handle object value.... will create another pr to support number only.

@yesmeck yesmeck closed this Sep 27, 2017
@yesmeck yesmeck deleted the option-any-value branch September 27, 2017 09:23
@yesmeck yesmeck mentioned this pull request Sep 27, 2017
Merged
@Mr-haili Mr-haili mentioned this pull request Aug 25, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yesmeck @coveralls