fix: delay to close in combobox #402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://rc-select-git-combo-fix.react-component.now.sh |
afc163
reviewed
May 14, 2019
src/Select.tsx
Outdated
|
|
||
| // Hard close popup to avoid lock of non option in combobox mode | ||
| if (isRealOpen && combobox && defaultActiveFirstOption === false) { | ||
| setTimeout(() => { |
|
Updated. Please check. |
afc163
approved these changes
May 14, 2019
|
Did this resolve ant-design/ant-design#16568 ? |
|
DatePicker may have better solution (refactor 😄~ ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复比较恶心，Select 本身不管 Menu 里的状态，如果要判断是否当前有 active 的选项需要扒 Menu 的 mini-store 里的值。
为了不要这么耦合，折中选取 combobox 模式下且 defaultActive 为 false 时，按了 enter 后自动关闭 popup，以使得行为可以透传出来。
fix ant-design/ant-design#16572