Skip to content

feat: Support legacy props param with warning #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2019
Merged

feat: Support legacy props param with warning #424

merged 2 commits into from
Sep 17, 2019

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Sep 17, 2019

Follow code will work after this PR:

<Select filterOption={(input, option) => option.props.children.includes(input)} />

@vercel
Copy link

vercel bot commented Sep 17, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://rc-select-git-warning.react-component.now.sh

@zombieJ zombieJ requested a review from afc163 September 17, 2019 11:28
@zombieJ zombieJ merged commit b4ebb52 into master Sep 17, 2019
@delete-merged-branch delete-merged-branch bot deleted the warning branch September 17, 2019 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 Awaiting requested review from afc163

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zombieJ